The Rivet MC analysis system: Todo List

The Rivet MC analysis system 2.1.0

Group Access jet constituents

Add a constructor from PseudoJet

Member Analysis::_analysisobjects

Make this a map for fast lookup by path?

Member Analysis::addAnalysisObject (AnalysisObjectPtr ao)

2D versions of integrate... defined how, exactly?!?

Member Analysis::analysisObjects () const

Add integrate helpers for 2D histos (defined somehow...)

Member Analysis::bookProfile1D (const std::string &name, size_t nbins, double lower, double upper, const std::string &title="", const std::string &xtitle="", const std::string &ytitle="")

Add booking methods which take a path, titles and *a reference Scatter from which to book*

Member Analysis::getAnalysisObject (const std::string &name)

Use this default function template arg in C++11

Member Analysis::getAnalysisObject (const std::string &name) const

Use this default function template arg in C++11

Member Analysis::histoDir () const

Cache in a member variable

Member Analysis::integrate (Histo1DPtr h, Scatter2DPtr s) const

2D versions of scale and normalize...

Member Analysis::needsCrossSection () const

Remove this and require HepMC >= 2.06

Member Analysis::setNeedsCrossSection (bool needed=true)

Remove this and require HepMC >= 2.06

Member AnalysisHandler::addAnalysis (const std::string &analysisname)

Might we want to be able to run an analysis twice, with different params? Requires avoiding histo tree clashes, i.e. storing the histos on the analysis objects.

Member AnalysisLoader::_loadAnalysisPlugins ()

Make sure this is an abs path

Sys-dependent path separator instead of "/"

Member ARGUS_1993_S2653028::analyze (const Event &e)

Use better looping

Member ARGUS_1993_S2653028::findDecayProducts (const GenParticle *p, vector< GenParticle * > &pionsA, vector< GenParticle * > &pionsB, vector< GenParticle * > &protonsA, vector< GenParticle * > &protonsB, vector< GenParticle * > &kaons)

Use better looping

Member ARGUS_1993_S2669951::finalize ()

Better to group these by coherent 'if (weightSum_X)' statements?

Member ARGUS_1993_S2669951::findDecayProducts (const GenParticle *p, Particles &unstable)

Use better looping

Member ARGUS_1993_S2789213::analyze (const Event &e)

Use better looping

Replace with Counters and fill one-point Scatters at the end

Member ARGUS_1993_S2789213::finalize ()

Replace with Counters and fill one-point Scatters at the end

Member ARGUS_1993_S2789213::findDecayProducts (const GenParticle *p, Particles &unstable)

Use better looping

Member ATLAS_2010_S8894728::_moments_to_stddev (Profile1DPtr moment_profiles[], Scatter2DPtr target_dps)

Assuming unit weights here! Should use N_effective = sumW**2/sumW2?

Member ATLAS_2011_I926145::init ()

Bare Zs ...

... but dressed Ws?

Member ATLAS_2011_I944826::finalize ()

Replace with normalize()?

Member ATLAS_2011_I945498::selectJets (const ZFinder *zf, const FastJets *allJets)

Replace with a Cut passed to jetsByPt

Member ATLAS_2011_S9002537::_tmp_h_minus

Will need to register TMP histograms for future histogramming

Member ATLAS_2011_S9002537::_tmp_h_minus

Will need to register TMP histograms for future histogramming

Member ATLAS_2011_S9002537::init ()

Will need to register TMP histograms for future histogramming

Class ATLAS_2011_S9041966

Clean up the debug stuff

Class ATLAS_2011_S9126244

Make sure that temp histos are removed

Member ATLAS_2011_S9126244::finalize ()

Clean up temp histos -- requires restructuring the temp histo struct

Member ATLAS_2011_S9126244::finalizeQ0GapFraction (double totalWeightSum, Scatter2DPtr gapFractionDP, Histo1DPtr vetoPtHist)

Should be convertible to a YODA ~one-liner using toIntegralEfficiencyHisto

Member ATLAS_2011_S9128077::analyze (const Event &event)

It'd be better to avoid duplicating 95% of the code!

Member ATLAS_2012_I1091481::init ()

Initialise and register projections here

Member ATLAS_2012_I1093734::finalize ()

Should the difference always be shown as positive?, i.e. y -> abs(y), etc.

Should the normalization be done _after_ the -ve value treatment?

Member ATLAS_2012_I1093734::init ()

Declare/book as temporary

Member ATLAS_2012_I1093734::PTMINVALUES [NPTBINS]

Initialize these inline at declaration with C++11

Member ATLAS_2012_I1094568::analyze (const Event &event)

This is a hack -- replace with UnstableFinalState

Use MissingMomentum instead?

Member ATLAS_2012_I1094568::finalizeGapFraction (double total_weight, Scatter2DPtr gapFraction, Histo1DPtr vetoPt)

Should be possible to replace this with a couple of YODA one-lines for diff -> integral and "efficiency division"

Get rid of this and use vetoPt->integral(i+1) when points and bins line up?

Delete vetoPt temp histos: use /TMP system

Member ATLAS_2012_I1118269::analyze (const Event &event)

In future, convert to use built-in 'last B hadron' function

Member ATLAS_2012_I1119557::_h_planarFlow

Commented eccentricity out for now: reinstate

Member ATLAS_2012_I1119557::analyze (const Event &event)

Commented eccentricity out for now: reinstate

Member ATLAS_2012_I1119557::finalize ()

Commented eccentricity out for now: reinstate

Member ATLAS_2012_I1119557::init ()

Commented eccentricity out for now: reinstate

Member ATLAS_2013_I1230812::analyze (const Event &event)

Replace with a Cut passed to jetsByPt

Member ATLAS_2013_I1230812::init ()

Note that Zs are accepted with any rapidity: the cuts are on the e/mu: is this correct?

Member ATLAS_2013_I1243871::analyze (const Event &event)

Why rewrite the jets collection as a vector of pointers?

Use direct kinematics access

Use built-in identification on Particle, avoid HepMC

Use built-in dR < 0.3 Jet tagging, avoid HepMC

Use direct momentum accessor / delta functions

Use built-in b-tagging (dR < 0.3 defn), avoid HepMC

Use direct momentum accessor / delta functions

Use C++11 vector/array initialization

Use YODA bin index lookup tools

Member BABAR_2003_I593379::findDecayProducts (const GenParticle *p, vector< GenParticle * > &allJpsi, vector< GenParticle * > &primaryJpsi, vector< GenParticle * > &Psiprime, vector< GenParticle * > &all_chi_c1, vector< GenParticle * > &all_chi_c2, vector< GenParticle * > &primary_chi_c1, vector< GenParticle * > &primary_chi_c2)

Use better looping

Member BABAR_2005_S6181155::findDecayProducts (const GenParticle *p, unsigned int &nstable, unsigned int &npip, unsigned int &npim, unsigned int &nXip, unsigned int &nXim)

Use better looping

Member BABAR_2007_S7266081::findDecayProducts (const GenParticle *p, unsigned int &nstable, Particles &pip, Particles &pim, Particles &Kp, Particles &Km)

Use better looping

Member BELLE_2001_S4598261::analyze (const Event &e)

Use better looping

Member BELLE_2001_S4598261::findDecayProducts (const GenParticle *p, vector< GenParticle * > &pions)

Use better looping

Member BELLE_2006_S6265367::analyze (const Event &e)

Use better looping

Member BELLE_2006_S6265367::findDecayProducts (const GenParticle *p, unsigned int &nstable, unsigned int &npip, unsigned int &npim, unsigned int &np, unsigned int &nap, unsigned int &nKp, unsigned int &nKm, unsigned int &nPhi)

Use better looping

Member CDF_1996_S3108457::analyze (const Event &event)

include gaussian jet energy resolution smearing?

Member CDF_1996_S3108457::init ()

Ratios of mass histograms left out: Binning doesn't work out

Member CDF_1996_S3349578::analyze (const Event &event)

include gaussian jet energy resolution smearing?

Member CDF_2004_S5839831::finalize ()

Take these normalisations from the data histo (it can't come from just the MC)

Member CDF_2006_S6653332::analyze (const Event &event)

Use jet contents rather than accessing quarks directly

Use nicer looping

Use jet contents rather than accessing quarks directly

Use nicer looping

Use jet contents rather than accessing quarks directly

Member CDF_2008_S7540469::analyze (const Event &event)

Make this neater, using the JetAlg interface and the built-in sorting

Member CDF_2008_S7541902::analyze (const Event &event)

This isn't really a histogram: replace with a YODA::Counter when we have one!

Member CDF_2008_S7541902::finalize ()

This special case for 1-to-0 will disappear if we use Counters for all mults including 0.

Member CDF_2008_S7541902::init ()

These would be better off as YODA::Counter until finalize()

Member CDF_2008_S8095620::analyze (const Event &event)

: write out a warning if there are more than two decay products

Use a b-hadron search rather than b-quarks for tagging

Class CDF_2009_S8057893

Finish!

Member CDF_2009_S8233977::analyze (const Event &evt)

The pT and sum(ET) distributions look slightly different from Niccolo's Monte Carlo plots. Still waiting for his answer.

Member CDF_2010_S8591881_DY::analyze (const Event &e)

Replace with foreach

Replace with PID::isLepton

Member CDF_2010_S8591881_QCD::analyze (const Event &e)

Implement Run II min bias trigger cf. CDF_2009?

Member CentralEtHCM::project (const Event &e)

Generalise rapidity cut value

Member CMS_2011_S9215166::analyze (const Event &event)

"Diffractive" veto should really also veto dijet events?

Member CMS_2012_I1102908::init ()

Can we manage to only register these as they are "really" created in the finalize()?

Member CMS_2012_I941555::init ()

Really?: ZFinder zfinder_dressed_mu_pt(-2.1, 2.1, 20, PID::MUON, 60*GeV, 120*GeV, 0.2, false, true);

Member CMS_2013_I1224539_DIJET::findPtBin (double ptJ)

Use a YODA axis/finder alg when available

Member CMS_2013_I1224539_WJET::findPtBin (double ptJ)

Use a YODA axis/finder alg when available

Member CMS_2013_I1224539_WJET::isBackToBack_wj (const WFinder &wf, const fastjet::PseudoJet &psjet)

We should make FourMomentum know how to construct itself from a PseudoJet

Member CMS_2013_I1224539_ZJET::findPtBin (double ptJ)

Use a YODA axis/finder alg when available

Member CMS_2013_I1224539_ZJET::isBackToBack_zj (const ZFinder &zf, const fastjet::PseudoJet &psjet)

We should make FourMomentum know how to construct itself from a PseudoJet

Member ConstRandomFilter::operator() (const Particle &)

Use a better RNG

Group Convenience access to the effective 4-vector properties

Add a cast operator to FJ3 PseudoJet

Group Convenience access to the effective 4-vector properties

Add a cast operator to FJ3 PseudoJet

Group Convenience access to the effective 4-vector properties

Add a cast operator to FJ3 PseudoJet

Group Convenience access to the effective 4-vector properties

Add a cast operator to FJ3 PseudoJet

Member D0_1996_S3214044::init ()

Use correct jet algorithm

Member D0_1996_S3324664::finalize ()

Understand this!

Prefer to scale rather than normalize, if possible

Member D0_1996_S3324664::init ()

Use correct jet algorithm

Member D0_2008_S6879055::finalize ()

Use integrals of refData()?

Member D0_2008_S7837160::analyze (const Event &event)

Is it correct to multiply the eta sign into the charge to "fold" the plot?

Member D0_2008_S7837160::init ()

Use separate pT and ETmiss cuts in WFinder

Member D0_2008_S7863608::init ()

These clustering arguments look odd: are they ok?

Member D0_2009_S8202443::analyze (const Event &e)

Replace this explicit selection with a Cut

Member DELPHI_2003_WUD_03_11::finalize ()

Scale rather than normalize?

Member E735_1998_S3905616::init ()

E735 trigger?

Member Event::_geNormAlignment ()

Is there an e+ e- convention for longitudinal boosting, e.g. at B-factories? Different from LEP?

Member Event::_init (const GenEvent &ge)

When we can require C++11, constructors can call each other and this can be removed.

Enable this when HepMC has been fixed to allow printing to a stream like the Rivet logger.

Member Event::_originalGenEvent

Provide access to this via an Event::originalGenEvent() method? If requested...

Member Event::weight () const

This needs to be revisited when we finally add the mechanism to support NLO counter-events and weight vectors.

Member FastJets::_init3 (fastjet::JetDefinition::Plugin *plugin)

Should we be copying the plugin?

Member FastJets::_pseudojetsToJets (const PseudoJets &pjets) const

Cache?

Member FastJets::clusterSeqArea () const

Throw error if no area def? Or just blindly call dynamic_cast?

Member FastJets::reset ()

_cseq = fastjet::ClusterSequence();

Member FinalState::compare (const Projection &p) const

HOW DO WE COMPARE CUTS OBJECTS?

Member FinalState::project (const Event &e)

In general, we'd like to calculate a restrictive FS based on the most restricted superset FS.

Member FourMomentum::boostVector () const

Be careful about c=1 convention...

Member FoxWolframMoments::FoxWolframMoments (const FinalState &fsp)

Let the user supply any projection they like?

Member FoxWolframMoments::getFoxWolframMoment (unsigned int l) const

What?!?

Member H1_1994_S2919893::analyze (const Event &event)

Use units in w comparisons... what are the units?

Is this profile meant to be filled with 2 weight factors?

Use angle function

Is this profile meant to be filled with 2 weight factors?

Use angle function

Class H1_1995_S3167097

Make histograms match those in HepData and use autobooking

Member H1_1995_S3167097::finalize ()

Improve this!

Member H1_1995_S3167097::init ()

Convert to use autobooking and correspond to HepData data tables

Member H1_2000_S4129130::finalize ()

Simplify by using normalize() instead? Are all these being normalized to area=1?

Class HeavyHadrons

This assumes that the heavy hadrons are unstable... should we also look for stable ones in case the decays are disabled?

Member HeavyHadrons::project (const Event &e)

What about charm hadrons coming from bottom hadron decays?